Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2005:
[Freeciv-Dev] Re: (PR#12703) bug: harbour not giving food?
Home

[Freeciv-Dev] Re: (PR#12703) bug: harbour not giving food?

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: bh@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#12703) bug: harbour not giving food?
From: "Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>
Date: Sun, 3 Apr 2005 13:04:28 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12703 >

On Sun, 3 Apr 2005, Vasco Alexandre da Silva Costa wrote:

>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12703 >
>
> On Sat, 2 Apr 2005, Benoit Hudson wrote:
>
> > <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12703 >
> >
> > Patch attached.
>
> That patch will not do anything. The problem is most likely that whoever
> should be calling get_city_tile_bonus isn't calling it properly. I know
> the semantics are weird, but its meant to be like this. The effect only
> applies to tiles inside city range.

Ah forget about it... Your patch should work. I made a simpler fix,
albeith uglier, fix here, just made get_city_tile_bonus use
TARGET_BUILDING, which is also LOCAL range. Yes, that is twisted.

That part of the code needs a good kicking.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa







[Prev in Thread] Current Thread [Next in Thread]