[Freeciv-Dev] (PR#12681) can_player_build_improvement Ignores Future Improvements

["Benedict Adamson" <badamson@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12681 >

The commentary of the function can_player_build_improvement in 
improvement.c says this:
   Whether player can _eventually_ build given building somewhere -- i.e.,
   returns TRUE if building is available with current tech OR will be
   available with future tech.  Returns FALSE if building is obsolete.
However, looking at the logic of the function, it seems to ignore the 
possibility that the building 'will be available with future tech'. This 
is a problem in the current beta version.
I suspect it ought to say
   return improvement_exists(id) && !improvement_obsolete(p, id);
However, I know very little about the improvements code.