[Freeciv-Dev] Re: (PR#12667) A few modpack fixes

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12667 >

Per I. Mathisen wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12667 >
> 
> CHANGES:
>  - Correctly handle rulesets with no F_HELP_WONDER units
>  - Generate actually helpful error messages from gen req code
>  - Do no try to unleash barbarians if there are no barbarian units in the
>    ruleset
>  - Allow rulesets with no barbarians or hut units
>  - Moved some freeciv-specific defines from shared.h to fc_types.h

Good.

>  - Add init_units="" list to nation rulesets where you add specific units
>    this nation should start the game with

Also good, but this should be a separate patch IMO.

> I would also like to say that writing rulesets became quite a bit more
> daunting with effects.ruleset, although the game mechanics it allows are
> quite neat.

Maybe we could allow effects to be put in any of the ruleset files? 
Then you can put an [effect_library] effect right underneath the 
[building_library] building in buildings.ruleset.

-jason