Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2005:
[Freeciv-Dev] Re: (PR#12635) Use freeciv specific functions instead of t
Home

[Freeciv-Dev] Re: (PR#12635) Use freeciv specific functions instead of t

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#12635) Use freeciv specific functions instead of the "raw" ones
From: "Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>
Date: Fri, 25 Mar 2005 08:52:01 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12635 >

On Fri, Mar 25, 2005 at 07:54:35AM -0800, Benoit Hudson wrote:
> 
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12635 >
> 
> On Fri, Mar 25, 2005 at 04:11:14AM -0800, Raimar Falke wrote:
> > Mostly prefixing with "my". I change some snprints to cat_snprints.
> 
> Why is it "my" instead of "fc" ?  I've long wondered.

The same as why is it "struct Sprite" and not "struct sprite": it is
this way ;)

> > -  snprint_production(prodstr, sizeof(prodstr), ptype->production);
> > +  my_snprint_production(prodstr, sizeof(prodstr), ptype->production);
> 
> Overzealous search & replace (several instances of this), or
> underzealous as you didn't change the function name.

Overzealous. The compile check should have caught it. But it didn't
because it is disabled normally. Well you did :)

        Raimar

-- 
 email: i-freeciv-lists@xxxxxxxxxxxxx
 "SIGDANGER - The System is likely to crash soon"





[Prev in Thread] Current Thread [Next in Thread]