[Freeciv-Dev] Re: (PR#12179) xaw-client YACP (yet another compile problem)

["Egor Vyscrebentsov" <evyscr@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12179 >

On Tue, 8 Feb 2005 21:16:06 -0800
Vijay Kiran Kamuju <infyquest@xxxxxxxxx> wrote:

VKK>here is the patch:
VKK>
VKK>> cma_fe.c:77: error: parse error before ')' token
VKK>> cma_fe.c: In function `show_cma_dialog':
VKK>> cma_fe.c:339: warning: implicit declaration of function 
`update_cma_preset_list'
VKK>> 
VKK>> cma_fe.c: At top level:
VKK>> cma_fe.c:371: warning: `update_cma_preset_list' was used with no 
prototype befor
VKK>> e its definition
VKK>> cma_fe.c:371: warning: `update_cma_preset_list' was declared implicitly 
`extern'
VKK>>  and later `static'
VKK>> cma_fe.c:339: warning: previous declaration of `update_cma_preset_list'
VKK>> cma_fe.c:371: warning: type mismatch with previous implicit declaration
VKK>> cma_fe.c:339: warning: previous implicit declaration of 
`update_cma_preset_list'
VKK>> 
VKK>> cma_fe.c:371: warning: `update_cma_preset_list' was previously implicitly 
declar
VKK>> ed to return `int'
VKK>> cma_fe.c: In function `update_cma_preset_list':
VKK>> cma_fe.c:386: warning: passing arg 2 of `XawListChange' from incompatible 
pointe
VKK>> r type
VKK>> make[4]: *** [cma_fe.o] Error 1

I think that this patch is not enough, because of warning in cma_fe.c:386.

Who was the author of change from:

char *initial_preset_list[] = {
      N_("For information on:"),
      N_("CMA and presets"),
      N_("including sample presets,"),
      N_("see README.cma."),
      "                  ",
      "                  ",
      "                  ",
      "                  ",
      0};

to:

char *initial_preset_list = N_("For information on\n"
                              "the citizen governor and governor presets,\n"
                              "including sample presets,\n"
                              "see README.cma.");
?

What were reasons for this? I'm afraid, it break any trying to view an initial 
text in CMA.
Is there any objections to revert this change?

Thanks, evyscr.

PS. Attached patch should allow compile Xaw client with enabled debug mode. But 
i think
it's not enough for client to work.

Index: client/gui-xaw/cma_fe.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-xaw/cma_fe.c,v
retrieving revision 1.10
diff -u -r1.10 cma_fe.c
--- client/gui-xaw/cma_fe.c     10 Feb 2005 18:39:22 -0000      1.10
+++ client/gui-xaw/cma_fe.c     16 Feb 2005 14:22:23 -0000
@@ -74,10 +74,12 @@
 
 int minimal_surplus[O_MAX], factors[O_MAX + 1];
 struct city *current_city;
-char *initial_preset_list = N_("For information on\n"
-                              "the citizen governor and governor presets,\n"
-                              "including sample presets,\n"
-                              "see README.cma.");
+char *initial_preset_list[] = {
+       N_("For information on\n"
+       "the citizen governor and governor presets,\n"
+       "including sample presets,\n"
+       "see README.cma."),
+       NULL};
 
 
 static void update_cma_preset_list(void);