[Freeciv-Dev] Re: (PR#11336) [Patch] movetype.[ch]

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11336 >

On Wed, 29 Dec 2004, Gregory Berkolaiko wrote:

> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=11336 >
>
> >   Renamed is_water_unit() -> is_sailing_unittype() for consistency. We
> > now have:
> >   is_ground_unit() & is_ground_unittype(),
> >   is_air_unit() & is_air_unittype(),
> >   is_heli_unit() & is_heli_unittype(),
> >   is_sailing_unit() & is_sailing_unittype()
>
> Please consider the following:
> is_ground and is_air refer to the substance in/on which the movement is
> performed.
> is_sailing refers to the way the movement is done
>
> So I think is_sea_unit is better (and shorter too!)
>
> The reason I am asking is because I could never remember the name
> is_sailing...

I believe the military call these spheres Land, Sea and Air.

The code for helis vs air units is just plain weird. I think this should
be re-thought.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa