[Freeciv-Dev] Re: (PR#11336) [Patch] movetype.[ch]

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11336 >

Marko Lindqvist wrote:

>   Replaced your unit_can_defend_here() comment with comment of my own 
> and changed code to comply. Behavior (for existing rulesets) is not 
> changed, but implementation is more general (handles sea units 
> transported by land units etc)

> +/****************************************************************************
> +  Return TRUE iff the unit can be a defender at its current location.  This
> +  should be checked when looking for a defender - not all units on the
> +  tile are valid defenders.
> +****************************************************************************/
> +bool unit_can_defend_here(struct unit *punit)
> +{
> +  /* Even transported units may step out from transport to fight,
> +     if this is their native terrain. */
> +  if (can_unit_exist_at_tile(punit, punit->tile)) {
> +    return FALSE;
> +  }
> +  
> +  return TRUE;
> +}

This looks backward.  If the unit can exist at this tile (without a 
transporter) you want to return TRUE, not the other way around.  So this 
function should just be

{
   return can_unit_exist_at_tile(punit, punit->tile);
}

-jason