Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#11282) [C++] typedef / struct member conflict in c
Home

[Freeciv-Dev] Re: (PR#11282) [C++] typedef / struct member conflict in c

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: fbriere@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#11282) [C++] typedef / struct member conflict in client/climisc.h
From: "Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>
Date: Thu, 2 Dec 2004 13:39:45 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11282 >

On Wed, 1 Dec 2004, [UTF-8] Frédéric Brière wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=11282 >
>
> On Wed, Dec 01, 2004 at 10:52:00AM -0800, Jason Short wrote:
> > Just change the 'cid' type to cid_type.  Or even better, figure out what
> > 'cid' is supposed to mean and give it a legible name.
>
> On closer evaluation, there appear to be 200+ instances of cid, either
> as a typedef, a struct member, a variable, or part of a function name.
> I'm a bit reluctant, to say the least, about embarking on such a massive
> renaming odyssey.
>
> Vasco, do you still think __cplusplus is unacceptable in this case?

What was the issue again? That the type name was the same as some
struct member name? Just rename the thing with less occurences so there
is no clash anymore. You do not need to rename everything.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa






[Prev in Thread] Current Thread [Next in Thread]