[Freeciv-Dev] Re: (PR#10889) xaw: no confirmation dialog for targeted revolutions

["Egor Vyscrebentsov" <evyscr@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10889 >

On Sat, 20 Nov 2004 10:22:26 -0800
Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:

> Egor Vyscrebentsov wrote:
> >
> > Attached patch shows confirmation dialog when player has no
> > revolution.
> >
> > One problem - next turn after revolution finished it does not
> > show this dialog. Two (or more) turns ater finish it does.
> > Civserver debug log shows that revolution_finishes is -1, however...
skipped
> 
> I think you're doing the wrong thing.  There isn't supposed to be a 
> popup at the end of the revolution.  There's just supposed to be a 
> confirmation popup at the beginning of the revolution.  The "Really 
> start revolution?" popup should be shown whether the player chooses a 
> government or not.

This is a problem with showing dialog _after clicking on government menu item_
(change to government) next turn your previous revolution ended.
So new revolution started without confirmation.

> So the popup should be a direct result of selecting the menu item, not 
> something that happens some turns later.  However the popup should only 
> be called if (I think) revolution_finishes == -1.  So it will only give 
> you a popup when you _start_ a revolution.

Yes, this was my thought when i made patch. However, see above...

> These dialogs may also turn 
> up in the middle of a revolution (game.revolution_finishes < game.turn) 
> or at the end of a revolution before a government is chosen 
> (game.revolution_finishes >= game.turn) and you don't want a popup in 
> either of those cases.  So, both you and Vasco are wrong.

Thanks, evyscr.