[Freeciv-Dev] Re: (PR#11091) put specialists into the cityrep dynamically

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11091 >

Christian Knoke wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=11091 >
> 
> On Fri, Nov 19, 2004 at 03:55:33PM -0800, Jason Short wrote:
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=11091 >
>>
>>This patch changes the city report fields to be ruleset-specific:
> 
> For the latecomers, can you explain what this gives, please?

It allows the cityrep to deal with changing numbers, types, and names of 
specialists in the ruleset.

As an example, SMAC had 9 different types of specialist which became 
available as new techs were discovered.

>>- The number of city report fields is dynamic.  This means no static 
>>data may use this value.
>>
>>- There are a bunch of "fixed" fields in an array in cityrepdata.c.
>>
>>- When rulesets are received new fields are added.  These new fields 
>>include a field for each specialist type.  The only problem here is that 
>>the fields may not be properly sorted.
> 
> Yes, they are put at the end, which is not so good.

Sorting is possible.  But is it that important?  The GUI should allow 
you to reorder these fields anyway (Vasco).

>>- Option values in .civclientrc are loaded only after the rulesets are 
>>received (just like worklists).
> 
> Reloading a default game, I can choose them from the display column menu,
> which is okay for me.
> 
> A problem, though, the column header text make this columns use lots space
> which is limited anyway.

This is a translation issue I think.  Perhaps we need a "short name" for 
the specialist.  The "names" in the ruleset are in any case not really 
intended for display so maybe we need a couple of different new 
ruleset-specified strings.

Can you give a screenshot showing your too-wide column names?

jason