[Freeciv-Dev] Re: (PR#10968) unload does not unload all

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10968 >

Jason Short wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10968 >
> 
> Christian Knoke wrote:
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=10968 >
>>
>>On Wed, Nov 10, 2004 at 10:17:23AM -0800, Jason Short wrote:
>>
>>
>>>Christian Knoke wrote:
>>
>>
>>>>Shift-U on transports does not unload/wake up all units.
>>>
>>>It works for me.  Can you provide a savegame?
>>
>>
>>Move transport out of Kedainiai and perform unload order for the transport
>>(Shift-U). Only 1 worker will wake up, all others keep loaded and sentried.
>>Note, if you <shift-u> in the city, *all* workers wake up.
> 
> A sea transporter outside of a city can't unload ground units.  The 
> intended behavior is that none of the units should be activated.  If you 
> "unload all" inside a city the units are not only woken up they are 
> unloaded.

Sorry; the intended behavior is that all of the units should be 
activated (but not unloaded since that's impossible).  It was just a 
typo bug.  Here's a fix.

I doubt that this will fix the unload-in-allied-cities bug though.

jason

? client/output
Index: client/control.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/control.c,v
retrieving revision 1.148
diff -u -r1.148 control.c
--- client/control.c    10 Nov 2004 02:10:36 -0000      1.148
+++ client/control.c    11 Nov 2004 16:26:21 -0000
@@ -722,7 +722,7 @@
       request_unit_unload(pcargo);
 
       if (pcargo->activity == ACTIVITY_SENTRY) {
-       request_new_unit_activity(punit, ACTIVITY_IDLE);
+       request_new_unit_activity(pcargo, ACTIVITY_IDLE);
       }
 
       plast = pcargo;