[Freeciv-Dev] (PR#10176) gtk2 client: goto-line not cancelled on /endgam
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://RT::WebBaseURL.not.configured:80/Ticket/Display.html?id=10176 >
> [jdorje - Wed Sep 22 03:42:00 2004]:
> > [marko.lindqvist@xxxxxxxxxxx - Sat Sep 18 12:53:26 2004]:
> > After server 'endgame', client still wants to know goto target for
> > goto requested earlier.
>
> This is easy to verify. This is surely a bug in the client/ code not in
> gui-gtk-2.0. When the game state changes the hover mode needs to be
> reset. Patch wanted.
Try this. IMHO the problem is that however added CLIENT_GAME_OVER_STATE
botched up the implementation in set_client_state().
I do think that branch should be moved to a proper place instead as
well, e.g. after client_state=newstate.
Index: client/civclient.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/civclient.c,v
retrieving revision 1.196
diff -u -r1.196 civclient.c
--- client/civclient.c 21 Sep 2004 05:00:50 -0000 1.196
+++ client/civclient.c 24 Sep 2004 17:27:56 -0000
@@ -430,6 +430,9 @@
cma_release_city(pcity);
}
} city_list_iterate_end;
+ popdown_all_city_dialogs();
+ popdown_all_game_dialogs();
+ set_unit_focus(NULL);
}
if (client_state != newstate) {
|
|