Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2004:
[Freeciv-Dev] Re: (PR#10121) pplayers_in_the_same_team 		Home

[Freeciv-Dev] Re: (PR#10121) pplayers_in_the_same_team

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mstefek@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#10121) pplayers_in_the_same_team
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 15 Sep 2004 08:23:09 -0700
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=10121 >

Per I. Mathisen wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10121 >
> 
> On Wed, 15 Sep 2004, Mateusz Stefek wrote:
> 
>>This patch adds a new function pplayers_in_the_same_team() and use it in
>>several places. None of these places are speed-critical. No behavior is
>>changed even though I can see a mistake in PR#10086
> 
> 
> I think it should be called "players_in_same_team". Using "the" in a
> function name is too verbose, and using "pplayer" in a function name is
> bad.

Yes.

jason
[Prev in Thread] Current Thread [Next in Thread]