[Freeciv-Dev] Re: (PR#10121) pplayers_in_the_same_team

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10121 >

On Wed, Sep 15, 2004 at 02:28:46AM -0700, Mateusz Stefek wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10121 >
> 
> > [per - Wed Sep 15 09:20:20 2004]:
> > 
> > On Wed, 15 Sep 2004, Mateusz Stefek wrote:
> > > This patch adds a new function pplayers_in_the_same_team() and use it in
> > > several places. None of these places are speed-critical. No behavior is
> > > changed even though I can see a mistake in PR#10086
> > 
> > I think it should be called "players_in_same_team". Using "the" in a
> > function name is too verbose, and using "pplayer" in a function name is
> > bad.
> > 

it should also be players_on_same_team() not in.

-mike