Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2004:
[Freeciv-Dev] Re: (PR#9324) startunits and sea units

[Freeciv-Dev] Re: (PR#9324) startunits and sea units

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#9324) startunits and sea units
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 29 Aug 2004 20:40:25 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: >

Marko Lindqvist wrote:
> <URL: >
>   Placing sea units on land will certainly cause lots of bugreports, if 
> we leave it to next release as it is. As temporary solution, attached 
> patch simply disallows sea units as startunits.
>   1) One cannot any longer put ferryboats (f) into startunits array with 
> 'set startunits'. I left later handling of satrtunits array as it is 
> (ferryboat handling is there already when they are allowed again)
>   2) There is check in place_starting_unit() that prevents sea unit 
> creation as startunit for any role.
>   2 could be much more elegant. It could report each unittype illegal 
> only once (currently reports every individual creation attempt). It 
> could also iterate over role unittypes to find out if there is also land 
> moving types available.
>   But this is meant to be quick and temporary fix, so I'm not putting 
> too much effort into it.

If 'f' is not allowed in the startunits server variable why is a check 
for it needed later?  Or more to the point, why does this check need a 
translatable string (rather than just an assertion or silent discard)?


[Prev in Thread] Current Thread [Next in Thread]