[Freeciv-Dev] Re: (PR#9362) use impr->sabotage value

["Jason Dorje Short" <jdorje@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9362 >

Jason Dorje Short wrote:

> The code right now gives 50% resistance to city walls or any city in the 
> capital.  The effects code I think gives 50% resistance to any building 
> in a city with city walls.  I assume the latter is wrong but I can't say 
> for sure.  Either way this should just be a matter of fiddling with the 
> rulesets (giving city walls either EFT_SPY_RESISTANT or just a reduced 
> sabotage value).

This is wrong.  The effects patch does it the same way I did, by giving 
city walls sabotage==50.

> There's also a bug in the effects patch, whereby the "protected" 
> buildings were given a flat 50% vulnerability even if this meant their 
> vulnerability was increased.  This is bad.  This is why I think the 
> patch needs to be split up to get sufficient scrutiny.

This is still a bug.

jason