Complete.Org: Mailing Lists: Archives: freeciv-dev: June 2004:
[Freeciv-Dev] (PR#9150) client/connectdlg_common.c needs to include sign
Home

[Freeciv-Dev] (PR#9150) client/connectdlg_common.c needs to include sign

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#9150) client/connectdlg_common.c needs to include signal.h
From: "Brett Albertson" <brett.albertson@xxxxxxxxxxxx>
Date: Wed, 30 Jun 2004 06:28:39 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9150 >

> [jdorje - Wed Jun 30 07:55:46 2004]:
> 
> 
> For what function or type?  (Since this is obscure I'd like to comment
it.)

Without signal.h it gives the following error.

make[3]: Entering directory `/var/tmp/freeciv/client'
if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../utility -I./include -I../common
-I../common/aicore -I../intl -I./agents     -O3 -fomit-frame-pointer
-Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes
-Wmissing-declarations -MT connectdlg_common.o -MD -MP -MF
".deps/connectdlg_common.Tpo" -c -o connectdlg_common.o
connectdlg_common.c; \
then mv -f ".deps/connectdlg_common.Tpo" ".deps/connectdlg_common.Po";
else rm -f ".deps/connectdlg_common.Tpo"; exit 1; fi
connectdlg_common.c: In function `client_kill_server':
connectdlg_common.c:122: warning: implicit declaration of function `kill'
connectdlg_common.c:122: error: `SIGTERM' undeclared (first use in this
function)
connectdlg_common.c:122: error: (Each undeclared identifier is reported
only once
connectdlg_common.c:122: error: for each function it appears in.)
connectdlg_common.c: In function `client_start_server':
connectdlg_common.c:229: error: `SIGTERM' undeclared (first use in this
function)
make[3]: *** [connectdlg_common.o] Error 1
make[3]: Leaving directory `/var/tmp/freeciv/client'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/freeciv/client'


Basically, kill and SIGTERM are undefined without signal.h

 
> Can you make a patch (with comment)?

attached

-- 
Brett Albertson
brett.albertson@xxxxxxxxxxxx

Attachment: signal.diff
Description: Binary data


[Prev in Thread] Current Thread [Next in Thread]