[Freeciv-Dev] (PR#9110) Win32: cleanup/update of city dialog

["James Canete" <use_less@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9110 >

This patch does the following:
- Updates city dialog info to match that in the GTK client
- Changed city_dialog_update_supported_units() and
city_dialog_update_present_units() by removing an unnecessary parameter
and streamlining them slightly.
- Changed some functions to accept a window handle instead of a device
context handle, making the callers look cleaner.
- Removed citydlgdc, now creating device contexts when needed and using
canvas functions as much as possible.

It's a little less than an atomic change. :) I should probably separate
it into a number of patches.

Also, I was thinking about switching "struct canvas" over to using
window handles instead of device contexts, to eliminate the possibility
of there being hanging device contexts.

I suspect that some client crashes were due to the app running out of
DCs, as a friend of mine noticed a complete lack of crashes upon
upgrading from WinME to WinXP.  Win95/98/ME has a hard limit of five DCs
per thread, IIRC.

This patch isn't perfect, it may be using even more DCs than before,
though I am still working on it.

-James Canete

win32-citydlg-cleanup.diff
Description: Binary data