[Freeciv-Dev] (PR#8975) cm clear_cache() called before build_cache3()

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8975 >

> [jdorje - Sun Jun 13 16:33:42 2004]:
> But without the assert added in there is no NULL dereference.  The 
> pointer is NULL but it's never dereferenced.

> But since this bug isn't fatal AFAICT I don't see why this would be 
> necessary.

Maybe this core is relevant to the discussion:

Program received signal SIGSEGV, Segmentation fault.
clear_cache () at cm.c:582
582           if (!cache3.results[i].combinations[j].is_valid) {
(gdb) bt
#0  clear_cache () at cm.c:582
#1  0x0804ff81 in server_game_free () at srv_main.c:1760
#2  0x0804e2cf in server_quit () at srv_main.c:684
#3  0x080551a4 in quit_game (caller=0x0) at stdinhand.c:4204
#4  0x080554ad in handle_stdin_input (caller=0x0, str=0x0, check=false)
    at stdinhand.c:4388
#5  0x08096af6 in handle_readline_input_callback (line=0x8bd18f0 "q")
    at sernet.c:169
#6  0x05f5e4f1 in rl_callback_read_char () from /usr/lib/libreadline.so.4
#7  0x080973a9 in sniff_packets () at sernet.c:555
#8  0x0804f35d in main_loop () at srv_main.c:1406
#9  0x0804f8d6 in srv_main () at srv_main.c:1525
#10 0x0804a118 in main (argc=3, argv=0xbfe57424) at civserver.c:161

Got this today while testing settlers patch. All I do to reproduce is
load a script, login, start and quit.

  - Per