[Freeciv-Dev] (PR#8796) bug(s) in city_increase_size

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8796 >

There are several problems with city_increase_size:

- It hard-codes the minimum city size for taxmen and scientists as 5.

- If auto-arrange-workers is called, the extra citizen is first made a 
taxman.  This may leave the city in a non-sane state if the population 
is too low.  It is fixed in the call to auto_arrange_workers but there's 
no guarantee that we won't hit a sanity check in the meantime.  The 
solution is easy: just make the extra citizen an elvis.  It makes no 
difference since auto_arrange_workers will change it anwyay.

jason