[Freeciv-Dev] (PR#8791) crash with civ1 ruleset

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8791 >

When running with the attached RC I get this crash:

 >
Game saved as civgame-3500.sav.gz
 >
Game saved as civgame-3000.sav.gz
 >
Game saved as civgame-2500.sav.gz
 >
Game saved as civgame-2000.sav.gz
 >
Game saved as civgame-1500.sav.gz
 >
Game saved as civgame-1000.sav.gz
 > Floating point exception (core dumped)


(gdb) bt
#0  0x081059fc in kill_desire (benefit=50, attack=0, loss=10, vuln=0,
     victim_count=1) at aiunit.c:822
#1  0x080fa685 in process_attacker_want (pcity=0x83ac1e0, value=50,
     victim_unit_type=2, veteran=0, x=42, y=16, best_choice=0xbffff6a0,
     boat=0x0, boattype=200) at advmilitary.c:843
#2  0x080fad55 in kill_something_with (pplayer=0x8244400, pcity=0x83ac1e0,
     myunit=0x82e2830, choice=0x83ac874) at advmilitary.c:1065
#3  0x080fb41f in military_advisor_choose_build (pplayer=0x8244400,
     pcity=0x83ac1e0, choice=0x83ac874) at advmilitary.c:1327
#4  0x080ff56f in ai_manage_cities (pplayer=0x8244400) at aicity.c:516
#5  0x08100f75 in ai_do_last_activities (pplayer=0x8244400) at aihand.c:319
#6  0x0804e235 in end_turn () at srv_main.c:493
#7  0x0804f9e2 in main_loop () at srv_main.c:1411
#8  0x080501b1 in srv_loop () at srv_main.c:1723
#9  0x0804fbcc in srv_main () at srv_main.c:1499
#10 0x0804a51c in main (argc=135525920, argv=0xbffff894) at civserver.c:161

(gdb) p attack
$1 = 0
(gdb) p vuln
$2 = 0
(gdb) p victim_count
$3 = 1

In civ1 there seem to be numerous units with a defense of 0.

A defense of 0 should be allowed!  So long as a unit with an attack of 0 
is never allowed to attack this unit.

jason

set seed 123456
set randseed 123456
create bob
set aifill 5
hard
set timeout -1
set endyear 0

set settlers 1
set explorer 0
rulesetdir civ1
set civstyle 1
set borders 0

start