Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2004:
[Freeciv-Dev] Re: Freeciv commit: per: Look for information in savegames
Home

[Freeciv-Dev] Re: Freeciv commit: per: Look for information in savegames

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: Freeciv commit: per: Look for information in savegames about where n...
From: Raimar Falke <i-freeciv-lists@xxxxxxxxxxxxx>
Date: Wed, 19 May 2004 23:23:21 +0200

On Wed, May 19, 2004 at 01:20:50PM -0700, Raimar Falke wrote:

> -  struct map_position *start_positions;      /* allocated at runtime */
> +  struct start_position {
> +    int x, y;
> +    Nation_Type_id nation; /* May be NO_NATION_SELECTED. */
> +  } *start_positions;        /* allocated at runtime */
>  };

The old comment was placed correctly. The new ones aren't.

>  void init_new_game(void)
>  {
> -  Nation_Type_id start_pos[MAX_NUM_PLAYERS];

> +#define NO_START_POS -1

Why is this needed? Why can't another bool array be used? Why not a
const with function scope? And when a define is used why isn't this
undefined after the function?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Two OS engineers facing a petri net chart:
        "dead lock in four moves!"


[Prev in Thread] Current Thread [Next in Thread]