[Freeciv-Dev] (PR#8766) win32: units leave black border trails

["James Canete" <use_less@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8766 >

In the win32 client, the units leave a black border when moved.

I've tracked this bug down to canvas_put_rectangle() in gui-win32/mapview.c.

In this function, it creates a rect using (canvas_x, canvas_y, canvas_x
+ width + 1, canvas_y + height + 1).

However this is wrong.  If we wanted say a 1x1 rect at (0,0), it would
create a (0, 0, 2, 2) rect, which is a 3x3 rect.  Even if we take into
account the fact that the right and bottom border aren't drawn, we still
get a 2x2 rect, which is too large.

The included patch fixes this.

-James Canete

win32-fixblacklines.diff
Description: Binary data