Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2004:
[Freeciv-Dev] Re: (PR#8643) RFC: new file for topology code
Home

[Freeciv-Dev] Re: (PR#8643) RFC: new file for topology code

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#8643) RFC: new file for topology code
From: "Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>
Date: Fri, 7 May 2004 07:20:35 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8643 >

On Thu, May 06, 2004 at 10:37:13AM -0700, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8643 >
> 
> Jason Short wrote:
> 
> > I'd like to create a new file common/topology for the topology code.  We 
> > have a growing amount of such code, and since a lot of it is inline it 
> > is cluttering up map.h.
> 
> > We might consider making all topology functions inline and having _only_ 
> > common/topology.h.
> 
> Not possible.  However we may eventually inline/macro more of the functions.
> 
> > If nobody's opposed to the general idea, I'll make a list of what code 
> > can be moved.
> 
> The list is quite long.  See the attachment.  Because of all the 
> iterators and long macros topology.h will be bigger than map.h.  But 
> topology.c will be much smaller than map.c.
> 
> If nobody still objects, I will make a patch.

I think this is a good idea since the current topologies aren't enough
for some people ;)

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "The primary purpose of the DATA statement is to give names to
   constants; instead of referring to pi as 3.141592653589793 at every
   appearance, the variable PI can be given that value with a DATA
   statement and used instead of the longer form of the constant. This
   also simplifies modifying the program, should the value of pi
   change."
    -- FORTRAN manual for Xerox Computers




[Prev in Thread] Current Thread [Next in Thread]