[Freeciv-Dev] Re: (PR#8662) [PATCH] tests/Makefile.am fixes

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8662 >

Marko Lindqvist wrote:

>   I'm not sure if we should run current tests for "make check". I think 
> that target "check" is meant to make sure that whaterver "make all" 
> produces is valid, not to analyze sources and such.  Then again, I don't 
> know if running these tests with "make check" has any actual downsides. 
> Maybe it confuses some users, maybe not.

The problem is there's not really any failure condition for these checks.

>   Biggest potential problem I can see is that maybe there is tools to 
> automatically compile and install distributed packages, which does 'make 
> check' and if package seems to be broken, aborts. We don't want such end 
> user tools to fail simply because some sourcefile does not fully comply 
> to freeciv style.

Indeed.

I think "make check" should run these scripts.  The scripts should never 
fail but should continue to generate output text like they do now.  In 
the future we may introduce new checks that might fail.

jason