[Freeciv-Dev] Re: (PR#8662) [PATCH] tests/Makefile.am fixes

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8662 >

On Wed, May 05, 2004 at 07:01:49PM +0300, Marko Lindqvist wrote:
> Jason Short wrote:
> 
> >
> >So does that mean your original patch is correct?
> 
>  Maybe :)
> 
>  For now both noinst_SCRIPTS and check_SCRIPTS work, but I don't know 
> which will be right solution ultimately. Read on.
> 
>  Oh, I claimed that patch fixes running tests from builddir. Well, I 
> changed commandline to run them, but I never looked into scripts 
> themselves. They may not work as expected when started from builddir. 
> Will Raimar as original script author look into this?

The scripts I mailed work the currend dir contains the source. However
the position of soource is easy to change in the scripts. Jason did
so. The source dir is now passed in as the first argument.

>  I'm not sure if we should run current tests for "make check". I think 
> that target "check" is meant to make sure that whaterver "make all" 
> produces is valid, not to analyze sources and such.

I agree. "make check" is normally used to test the created binaries.

We should add a seperate make goal. It should be weaker than "check"
or "validate". Maybe "examine", "inspect" or such.

> Then again, I don't know if running these tests with "make check"
> has any actual downsides. Maybe it confuses some users, maybe not.

I think it will confuse users.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  reality.sys corrupt. Reboot Universe? (y,n,q)