[Freeciv-Dev] Re: (PR#8521) sha.c crashes

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8521 >

Raimar Falke wrote:

>>>So we should drop the _virtual and just name it
>>>"unit_create". "unit_destroy" can then be used for both "unit_create"
>>>and "unit_clone". unittools.c:create_unit should be renamed to
>>>unittools.c:server_create_unit or similar to denote that more work is
>>>done here.
>>
>>Possibly.  This is just a matter of semantics, however.
>>
>>My point is that there are only two concepts: server/client unit and 
>>virtual unit.  A server/client unit is a subset/subclass of a virtual 
>>unit.  This may not be how the concept of a virtual unit started but it 
>>has undeniably evolved into this.
> 
> Since we want solutions, what do you suggest?

I want just one concept in the common code (plus the server/client 
concept).  Whether it is called a virtual unit or just a unit doesn't 
matter to me (but note we have virtual cities too, so the "virtual" 
naming system extends beyond units).

jason