[Freeciv-Dev] Re: (PR#8521) sha.c crashes

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8521 >

On Fri, 16 Apr 2004, Jason Short wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8521 >
>
> I don't think the logic of
>
>    punit = create_unit_virtual(...);
>    punit2 = unit_clone(punit);
>    destroy_unit_virtual(punit);
>    destroy_unit(punit2);
>
> is good at all.  If punit2 is a virtual unit (which it obviously is) it
> should be destroyed by destroy_unit_virtual.
>
> Which leads me to conclude that destroy_unit should be removed and
> unit_clone should be clone_unit_virtual.
>
> A "virtual" unit is the part of the unit allocation that is common
> between client and server.  We don't need two concepts for this.

Why not call it model or core instead of virtual?

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa