[Freeciv-Dev] Re: (PR#7246) Send origin of chat messages

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7246 >

Raimar Falke wrote:

>>- Take a look at PR#6523.  This is a more generalized version of the 
>>same concept, except that I use the player_no instead of the conn_id.
> 
> It _is_ the other solution which I didn't want because it changes _a
> lot_ of code.

I'm not saying you should implement PR#6523.  But please keep it in mind 
as a future extension of your work.

>>Is there a reason the conn_id is superior?  (As an aside, I haven't
>>given up on the PR#6523 idea.  But it will take some work to update
>>it I imagine.)
> 
> conn_id has more information. While it is currently almost the same it
> may change if multiple connections (user) control/observe a player.

How will this work with other events?  If a player declares war on us 
the server sends the conn_id of the player's connection?  What if this 
value isn't unique?

IMO it is easier to stick to the player_no.  But it probably doesn't 
matter all that much, since in most cases they are synonymous and in 
other cases you probably don't care which you have.

jason