[Freeciv-Dev] Re: (PR#8429) timeout setting

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8429 >

On Sun, Apr 04, 2004 at 07:28:28PM -0700, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8429 >
> 
> 
> >> - A timeout of -1 shouldn't mean command-line input is ignored.  It
> >> should just mean the server doesn't wait for it.
> >
> > You mean "input from stdin" instead of "command-line input"?!
> >
> > I disagree since autogames are development feature. Read
> > you-should-know-what-you-are-doing.
> 
> But they are enabled by default!
> 
> Currently we have
> 
>   #ifndef NDEBUG
> 
> for them.  We could change it to
> 
>   #if !defined DEBUG || defined DEVELOPMENT_VERSION
> 
> or something.  Also the help text should be change from
> 
>   N_("blah blah blah.  And development servers can use -1.")
> 
> to
> 
> #ifdef AUTOGAMES
>   N_("blah blah blah.  A setting of -1 means whatever.")
> #else
>   /* TRANS: same as blah blah blah above.
>   N_("blah blah blah.");
> #endif

I think you make this bigger than it is. How many complains did we got
"I set timeout to -1 and than it didn't work anymore". The current
text reads:

  If all players have not hit "Turn Done" before this time is up, then the
  turn ends automatically. Zero means there is no timeout. In DEBUG servers, a
  timeout of -1 sets the autogame test mode. Use this with the command
  "timeoutincrease" to have a dynamic timer.

A "test mode" is quite clearly not something like "production mode".

Either print out a message like 

   You enabled auto-made by setting timeout to -1. The server will not
   accept commands from the command line or clients and will terminate
   if the games ends.

or make a separate setting ("autogame") where you can state this in
the help.

> >> - Timeouts are measured with 1-second accuracy only.  Surely we should
> >> use the timer code for this...
> >
> > You want timeouts which fractions of a second? And why?
> 
> No, I don't want a 0.1 second timeout.  I want a 4-second timeout to mean
> 4 seconds, not sometimes 3.2 and sometimes 4.9.

Can you explain in more detail what is causing this?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I haven't lost my mind - it's backed up on tape somewhere."