[Freeciv-Dev] Re: (PR#7123) [FS#9]

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7123 >

On Wed, Mar 31, 2004 at 02:06:34AM -0800, Per I. Mathisen wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7123 >
> 
> On Sun, 28 Mar 2004, Raimar Falke wrote:
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=7123 >
> 
> --- real.clean/client/Makefile.am       Mon Jan 19 18:39:16 2004
> +++ project_fs9/client/Makefile.am      Fri Mar 12 12:44:03 2004
> +if CLIENT_GUI_FS
> +GUI_SUBDIR = gui-fs
> +endif
> 
> -SUBDIRS = $(GUI_SUBDIR) $(CLI_INCLUDE) agents
> +SUBDIRS = $(GUI_SUBDIR) $(CLI_INCLUDE) agents gui-fs
> 
> The last change should not be necessary. $(GUI_SUBDIR) should already
> contain "gui-fs".

I will try this.

> In back_end_common_24.h:
> +#define P(image, x, y) ((image)->data + (image)->pitch * (y) + 4 * (x))
> 
> Shouldn't define such a short macro in a header file...

Hmmm. This header file is semi private and this P is used a lot. I
will change it.

> There are some odd changes to client/control.c. Those shouldn't be there,
> should they?

The first yes. The second no.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The Internet is really just a series of bottlenecks 
  joined by high speed networks."
    -- Sam Wilson