[Freeciv-Dev] Re: (PR#8424) moving a unit causes CMA to fail

["rwetmore@xxxxxxxxxxxx" <rwetmore@xxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8424 >


It may be normal in that unhappiness arises from another
source. But the CMA should not "release" the caravel, right?

Or is this a case where info is dynamically updated during
a turn rather than the CMA running off of cached stats that
are updated at specific point in the turn cycle to make
sure that the algorithms are consistent and reproducible?

Note:
This does/should not fix any unhappiness problem, and any
rearrangement of tiles that reduces shields to a level
that would cause a unit loss is presumably a *bad*
choice for the CMA algorithm, another potential bug.


Hopefully, one can sort out just where the error
actually is by walking the process in the debugger if
you actually have a savegame that brackets the series
of calls.

Cheers,
RossW
=====

Jason Short wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8424 >
> 
> Jason Short wrote:
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=8424 >
>>
>>I conquered a city.
>>
>>Then I moved a caravel into that city.
>>
>>Then the CMA for the caravel's hometown failed.  Unhappiness had become 
>>too high.  However the caravel was NOT causing any unhappiness.
>>
>>I'm pretty positive about the order.  I have savegames from before and 
>>after if needed.
> 
> 
> - Take the savegame game4.gz attached to the ticket; connect as jdorje.
> - Conquer the city with the horsemen.
> - Move the caravel into the city.
> 
> On the third step the caravel's homecity becomes unhappy and the CMA 
> releases it.
> 
> I think this is just a metter of delayed sending from server to client. 
>   THe server is updated but the client doesn't receive the info until 
> the "next move" (caravel moving into the city).  But perhaps I'm wrong 
> and this behavior is normal?  I hope not.
> 
> jason