[Freeciv-Dev] Re: (PR#8164) building out of a builddir: generate_packets.py

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8164 >

Raimar Falke wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8164 >
> 
> On Thu, Mar 25, 2004 at 02:51:33PM -0800, Jason Short wrote:
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=8164 >
>>
>>Here's an updated version of the patch.  I changed generate_packets.py
>>and its caller as Raimar suggested.
>>
>>packets_gen.h and packhand_gen.h are only included from one file each. 
>>However hand_gen.h is included from many files.  Should these be unified
>>so that it's included from just one header?  sernet.h and civserver.h
>>are the only two options, and neither is particularly good.
> 
> Can't we solve this <> addition with some more include magic? It seems
> wrong to me to add an exception for a rarely used case (different src
> and build dir).

I don't see how we can remove them entirely.  We can limit them to a 
single location if we wanted to.

If the original files weren't in the srcdir this wouldn't be a problem. 
  The problem is if we use "" the srcdir files are used instead of the 
builddir ones.  But this gets us nowhere since we certainly don't want 
someone building from a release tarball to have to rebuild the files.

jason