Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2004:
[Freeciv-Dev] Re: (PR#8164) building out of a builddir: generate_packets
Home

[Freeciv-Dev] Re: (PR#8164) building out of a builddir: generate_packets

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#8164) building out of a builddir: generate_packets.py
From: "Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>
Date: Fri, 26 Mar 2004 22:53:07 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8164 >

On Thu, Mar 25, 2004 at 02:51:33PM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8164 >
> 
> Here's an updated version of the patch.  I changed generate_packets.py
> and its caller as Raimar suggested.
> 
> packets_gen.h and packhand_gen.h are only included from one file each. 
> However hand_gen.h is included from many files.  Should these be unified
> so that it's included from just one header?  sernet.h and civserver.h
> are the only two options, and neither is particularly good.

Can't we solve this <> addition with some more include magic? It seems
wrong to me to add an exception for a rarely used case (different src
and build dir).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "- Amiga Y2K fixes (a bit late, wouldn't you say?)"
    -- Linus Torvalds about linux 2.4.0 at 4 Jan 2001




[Prev in Thread] Current Thread [Next in Thread]