[Freeciv-Dev] (PR#7778) Win32 client: moving a unit locks up mapview

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7778 >

> [use_less - Wed Mar 10 02:55:49 2004]:
> 
> In the win32 client, built from CVS, moving any unit causes the mapview
> to freeze.  Recentering or scrolling doesn't work.
> 
> It seems like windows doesn't like mapview_canvas.single_tile. (Macroed
> as  single_tile_pixmap) In draw_unit_animation_frame(), anyway.  The
> only way I could get it to display correctly when moving a unit was to
> make another struct canvas and use it instead of single_tile.  I also
> tried just making a bitmap, but it just ended up moving a large black
> rectangle around, though it didn't lock up the mapview like CVS.
> 
> Here's the patch for the version that creates a new canvas.  I also took
> the liberty of replacing all the bitblt calls with canvas_copy calls, so
> this could probably eventually be placed into mapview_common.  Though
> this might be a bad idea, since this is animation code.

I don't know how I broke this, but ultimately it will need to be fixed
since draw_unit_animation_frame will eventually be moved into
mapview_common.

Of course an immediate fix is the first priority.

jason