| [Freeciv-Dev] (PR#7637) Problem with line_width=2 [take 4][Top] [All Lists][Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
 
 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=7637 >
> [i-freeciv-lists@xxxxxxxxxxxxx - Sat Mar 06 20:55:34 2004]:
> 
> 
> The comment of gui_put_line is plain wrong:
> 
>   Draw a 1-pixel-width colored line onto the mapview or citydialog canvas.
> 
> since the function also draws 2-pixel-width lines
> 
> Additionally there is no clear semantic where the extra pixel of the 2
> pixel width line should be placed. For odd line widths it is clear but
> for even it isn't. Either this gets defined OR (what I would prefer)
> the border code deals with it and calls gui_put_line two times.
Very ugly.  I don't think it's possible to define it, since this depends
on the library code.  And I really don't want gui_put_line to be called
multiple times.
Another way to handle it would be to have the line_type specify the
"type" of line to draw: grid, border, worker, etc.  This puts some logic
back into the GUI (bad) but allows the GUI to deal with the problems
that might arise.
jason
 
 
 |  |