[Freeciv-Dev] Re: (PR#7279) Macro optimizations

["rwetmore@xxxxxxxxxxxx" <rwetmore@xxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7279 >



Raimar Falke wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7279 >
> 
> On Mon, Jan 26, 2004 at 07:49:11PM -0800, Jason Short wrote:
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=7279 >
>>
>>>[rwetmore@xxxxxxxxxxxx - Tue Jan 27 02:43:58 2004]:
>>
>>>If the maintainers have done their homework, understood ths issues,
>>>presented all the arguments and with the concensus of the community
>>>reached a decision to change core Freeciv standards or start a new
>>>version written in C++, then that is fine.
[...]
>>4. Inlining should only be used when it gives a substantial improvement
>>(in speed or code size) over macro or traditional function forms.
>>
[...]
> I want #4 reverted to read.
> 
> 4. Macros should only be used when it gives a substantial improvement
> (in speed or code size) over inlining or traditional function forms.
> 
>       Raimar


Said with the true understanding of an Iranian mullah. If you can't win
the election no big deal, just ensure you still select the candidates :-).


To reiterate from a previous post ...

 > You really should
 > look over the mail archives for the last 3 or so years. You will find
 > that almost every case where a code patch was said to provide greater
 > robustness or performance, it was rejected or required to scale an
 > arbitrarily high barrier of documented improvement. The alternative
 > cases simply need to say they are performance degrading, but with a
 > never documented whiney "not by much", and hey they are prettier :-).
 >
 > The death of a thousand cuts is part of the reason why there is so much
 > discussion of performance problems in the lists. Is is also why even
 > after the cleanup of a lot of robustness issues in the core, there have
 > been so many core faults and programmed aborts in the same period.
 > Rewriting code to make it pretty has dropped a lot of the original
 > logic, most often with catastrophic results.


It is clear one should reinstate the longstanding ban on inlines, and
maybe then Freeciv could just get back to writing new code features rather
than rewriting (and breaking/degrading) old code in a style purge.


Cheers,
RossW
=====