[Freeciv-Dev] (PR#7249) Auto settlers don't irrigate or mine

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7249 >

> [use_less - Fri Jan 23 00:16:52 2004]:
> 
> I decided to try to fix it myself.
> 
> This patch adds a plus sign.  :)
> 
> I have no idea if this is correct, but it seemed like the simplest fix
> to me, based on what the comments in the consider_settler_action()
> function said.  I tested it out quickly, and settlers do irrigate and
> mine now, but don't replace existing irrigation with mine and vice versa.

consider_settler_action is the most rediculous function I've ever seen.

Autosettlers will generally only improve terrain that is in use by a
city (except for roads which are built anywhere).  Having never looked
at this code before, I always thought this was intentional (although bad
behavior).  But I think you are right and this is just because of a
4-year-old typo in consider_settler_action.

jason