[Freeciv-Dev] Re: (PR#6672) tile coordinates revealed to user...inconsistently

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Jason Short wrote:
> Gregory Berkolaiko wrote:
> 
>>On Tue, 28 Oct 2003, Jason Short wrote:
>>
>>
>>
>>>When middle-clicking on a tile, the coordinates are only revealed to the 
>>>user if compiling with DEBUG.
>>>
>>>But the server always tells the user the coordinates of a tile that is 
>>>transformed from/into ocean.
>>>
>>>IMO coordinate numbers should be completely hidden from the user.  In 
>>>situations where the user would want to know them another means (like 
>>>the goto cross-head) should be found to give that information.
>>
>>
>>I am not sure what you mean by using the goto cross-head.
>>I also hope that you are not asking to remove the middle-click info in 
>>DEBUG mode, because it's one of the most useful features for debugging.
> 
> 
> No, I'm suggesting the coordinates be removed from the land<->sea 
> messages (except, possibly, when in debug mode).  If players need this 
> information it should be revealed in some more user-friendly way 
> (something like the goto crosshead - when you select the entry the 
> relevant tile is highlighted).

The attached patch removes the revealing of the coordinates.

One idea would be to say "Moved your engineers north due to changing 
land to sea."  Unfortunately "north" doesn't have a well-defined meaning 
to the user.

In most of these cases there is a unit moving, and so there are two 
pairs of coordinates involved.  It would be nice (especially for the 
teleport message) to reveal both pairs of coordinates to the user.  But 
currently we have no infrastructure for that.

jason

Index: server/unittools.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/unittools.c,v
retrieving revision 1.261
diff -u -r1.261 unittools.c
--- server/unittools.c  2003/10/29 08:00:39     1.261
+++ server/unittools.c  2003/10/29 15:54:45
@@ -936,8 +936,7 @@
            notify_player_ex(unit_owner(punit2),
                             punit2->x, punit2->y, E_UNIT_RELOCATED,
                             _("Game: Moved your %s due to changing"
-                              " land to sea at (%d, %d)."),
-                            unit_name(punit2->type), punit2->x, punit2->y);
+                              " land to sea."), unit_name(punit2->type));
            (void) move_unit(punit2, x, y, TRUE, FALSE, 0);
            if (punit2->activity == ACTIVITY_SENTRY)
              handle_unit_activity_request(punit2, ACTIVITY_IDLE);
@@ -959,8 +958,7 @@
            notify_player_ex(unit_owner(punit2),
                             punit2->x, punit2->y, E_UNIT_RELOCATED,
                             _("Game: Embarked your %s due to changing"
-                              " land to sea at (%d, %d)."),
-                            unit_name(punit2->type), punit2->x, punit2->y);
+                              " land to sea."), unit_name(punit2->type));
            (void) move_unit(punit2, x, y, TRUE, FALSE, 0);
            if (punit2->activity == ACTIVITY_SENTRY)
              handle_unit_activity_request(punit2, ACTIVITY_IDLE);
@@ -975,8 +973,7 @@
        notify_player_ex(unit_owner(punit2),
                         punit2->x, punit2->y, E_UNIT_LOST,
                         _("Game: Disbanded your %s due to changing"
-                          " land to sea at (%d, %d)."),
-                        unit_name(punit2->type), punit2->x, punit2->y);
+                          " land to sea."), unit_name(punit2->type));
        wipe_unit_spec_safe(punit2, FALSE);
        goto START;
       }
@@ -999,8 +996,7 @@
            notify_player_ex(unit_owner(punit2),
                          punit2->x, punit2->y, E_UNIT_RELOCATED,
                          _("Game: Moved your %s due to changing"
-                           " sea to land at (%d, %d)."),
-                         unit_name(punit2->type), punit2->x, punit2->y);
+                           " sea to land."), unit_name(punit2->type));
            (void) move_unit(punit2, x, y, TRUE, TRUE, 0);
            if (punit2->activity == ACTIVITY_SENTRY)
              handle_unit_activity_request(punit2, ACTIVITY_IDLE);
@@ -1021,8 +1017,7 @@
            notify_player_ex(unit_owner(punit2),
                             punit2->x, punit2->y, E_UNIT_RELOCATED,
                             _("Game: Docked your %s due to changing"
-                              " sea to land at (%d, %d)."),
-                            unit_name(punit2->type), punit2->x, punit2->y);
+                              " sea to land."), unit_name(punit2->type));
            (void) move_unit(punit2, x, y, TRUE, TRUE, 0);
            if (punit2->activity == ACTIVITY_SENTRY)
              handle_unit_activity_request(punit2, ACTIVITY_IDLE);
@@ -1037,8 +1032,7 @@
        notify_player_ex(unit_owner(punit2),
                         punit2->x, punit2->y, E_UNIT_LOST,
                         _("Game: Disbanded your %s due to changing"
-                          " sea to land at (%d, %d)."),
-                        unit_name(punit2->type), punit2->x, punit2->y);
+                          " sea to land."), unit_name(punit2->type));
        wipe_unit_spec_safe(punit2, FALSE);
        goto START;
       }
@@ -1294,9 +1288,9 @@
            unit_owner(punit)->name, unit_name(punit->type),
            src_x, src_y, pcity->name);
     if (verbose) {
-      notify_player(unit_owner(punit),
-                   _("Game: Teleported your %s from (%d, %d) to %s."),
-                   unit_name(punit->type), src_x, src_y, pcity->name);
+      notify_player_ex(unit_owner(punit), pcity->x, pcity->y, E_NOEVENT,
+                      _("Game: Teleported your %s to %s."),
+                      unit_name(punit->type), pcity->name);
     }
 
     if (move_cost == -1)
@@ -1320,9 +1314,9 @@
   } else {
     /* remove it */
     if (verbose) {
-      notify_player(unit_owner(punit),
-                    _("Game: Disbanded your %s at (%d, %d)."),
-                    unit_name(punit->type), punit->x, punit->y);
+      notify_player_ex(unit_owner(punit), punit->x, punit->y, E_NOEVENT,
+                      _("Game: Disbanded your %s."),
+                      unit_name(punit->type));
     }
     wipe_unit(punit);
   }