[Freeciv-Dev] Re: (PR#6260) server bug: city tile status

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Raimar Falke wrote:
> On Fri, Oct 10, 2003 at 05:46:33PM -0700, Jason Short wrote:
> 
>>Jason Short wrote:
>>
>>>Here's the general situation:
>>
>>>- auto_arrange_workers runs on the city.  But remember the city tile
>>>status hasn't been fully updated yet, since we didn't make it all the
>>>way through the loop.
>>
>>Here's a different tack...
>>
>>This patch makes sure the citymap is up-to-date before running through 
>>auto_arrange_workers.
>>
>>The logic here isn't as simple as it looks.  Since the update may cause 
>>re-entry into auto_arrange_workers we could end up going through the 
>>loop more than once.  But this happens anyway currently when things 
>>break down.  So although this is an ugly solution, it should be safe 
>>enough as a workaround.
> 
> 
> What is the status of this? In the thread someone said that this is
> similar to other issues. RT reflect this. But 1684 and 3546 are
> resolved. So this is another bug?!

1684 and 3546 were resolved with a workaround (which did nothing to 
prevent a recurrence of the bug elsewhere).

6260 now has a workaround which should prevent recurrences. 
auto_arrange_workers makes sure all tiles are up-to-date before 
optimizing.  This is slower but avoids the bugs.

jason