[Freeciv-Dev] Re: [resync] version 15 (PR#977) Extended connect dialog

["andrearo@xxxxxxxxxxxx" <andrearo@xxxxxxxxxxxx>]

On Sat, 4 Oct 2003, Daniel L Speyer wrote:
> Here's version 15 of the game starting patch.
>
> It's the same as version 14, except that it applies cleanly to today's
> CVS.  Well, it actually applies cleanly to today's CVS plus PR#6286,
> because what's the point in a path to help you load games if you can't
> load games?
>

I wanted to try your patch, but I couldn't get it to compile.
I'm using the CVS of today (6 Oct), here's the errors and warnings:
(BTW, I also found some codingstyle violations...)

kobben:~/idi/devel/freeciv-cvs-Oct-04:(506)$ make > /dev/null
configure: WARNING: I had to manually add -lncurses dependency to
make readline library pass the test.
configure: WARNING: I had to manually add -lncurses dependency to
make readline library pass the test.
ruleset.c:2930: warning: no previous prototype for `findrulesetdirs'
connectdlg.c:48:31: connectdlg_common.h: No such file or directory
connectdlg.c: In function `resume_game_callback':
connectdlg.c:220: warning: implicit declaration of function
`send_final_server_commands'
connectdlg.c: In function `select_player_callback':
connectdlg.c:231: `new_username' undeclared (first use in this function)
connectdlg.c:231: (Each undeclared identifier is reported only once
connectdlg.c:231: for each function it appears in.)
connectdlg.c: In function `handle_player_list_reply':
connectdlg.c:319: `current_filename' undeclared (first use in this
function)
connectdlg.c:330: `new_username' undeclared (first use in this function)
connectdlg.c: In function `get_aiskill_setting':
connectdlg.c:363: `NUM_SKILL_LEVELS' undeclared (first use in this
function)
connectdlg.c:364: `skill_level_names_translated' undeclared (first use in
this function)
connectdlg.c:365: `skill_level_names' undeclared (first use in this
function)
connectdlg.c: In function `file_ok':
connectdlg.c:389: `current_filename' undeclared (first use in this
function)
connectdlg.c:398: warning: implicit declaration of function
`send_initial_server_commands'
connectdlg.c: In function `find_load_filename':
connectdlg.c:441: `current_filename' undeclared (first use in this
function)
connectdlg.c: In function `send_save_game_with_filename':
connectdlg.c:467: `current_filename' undeclared (first use in this
function)
connectdlg.c: In function `page_prev_callback':
connectdlg.c:497: warning: implicit declaration of function
`client_kill_server'
connectdlg.c: In function `page_next_callback':
connectdlg.c:530: warning: implicit declaration of function
`client_start_server'
connectdlg.c:542: `client_has_hack' undeclared (first use in this
function)
connectdlg.c:584: `new_username' undeclared (first use in this function)
connectdlg.c: In function `gui_server_connect':
connectdlg.c:725: `NUM_SKILL_LEVELS' undeclared (first use in this
function)
connectdlg.c:727: `skill_level_names_translated' undeclared (first use in
this function)
make[4]: *** [connectdlg.o] Error 1
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
kobben:~/idi/devel/freeciv-cvs-Oct-04:(506)$