[Freeciv-Dev] Re: (PR#4447) traderoute info in popup

["andrearo@xxxxxxxxxxxx" <andrearo@xxxxxxxxxxxx>]

On Sat, 6 Sep 2003, Remi Bonnet wrote:
> I think the aim of this patch is great but there is errors in it:
>
> can_establish_trade_route() can be called only if can_cities_trade() has
> returned true or it will trigger an assert. i don't think the current
> behaviour is ok because can_establish_trade_route can return FALSE
> instead of dying if can_cities_trade return FALSE but you still need to
> correct this

The traderoute rules were changed after the patch was written.
I might write a new patch after the popups has been common`ized.

Andreas Røsdal