[Freeciv-Dev] (PR#4447) traderoute info in popup

["Remi Bonnet" <remi.bonnet@xxxxxxxxxxx>]

I think the aim of this patch is great but there is errors in it:

gtk_widget_new(GTK_TYPE_LABEL, "GtkWidget::parent", b,
                       "GtkLabel::label",
_("with City Walls"), NULL);
        count++;
+      }
+
+      if ((punit =
get_unit_in_focus())) {
+        struct city *tcity = find_city_by_id(punit-
>homecity);
+
+        if (unit_flag(punit, F_TRADE_ROUTE) &&
+
can_establish_trade_route(pcity, tcity)) {

can_establish_trade_route() can be called only if can_cities_trade() has
returned true or it will trigger an assert. i don't think the current
behaviour is ok because can_establish_trade_route can return FALSE
instead of dying if can_cities_trade return FALSE but you still need to
correct this

+          my_snprintf(s, sizeof(s),
_("Trade with %s: %d"),
+                      tcity->name,
trade_between_cities(pcity,tcity));

What if the two cities already have a traderoute?

Remi