[Freeciv-Dev] (PR#5082) [PATCH] packet_short_unit
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
[jdorje - Fri Aug 29 19:10:02 2003]:
> -
>
> /* Special case for a diplomat/spy investigating a city:
> The investigator needs to know the supported and present
> units of a city, whether or not they are fogged. So, we
> send a list of them all before sending the city info. */
>
> Is this really needed for both packet_short_unit and packet_unit? The
> info isn't send with packet_unit, so I suspect not. If so it should
> be
> separated into a helper function.
Oops, I see now that the duplicate is required because of the
non-manditory capability. Given how much code can be removed by making
the capability manditory, I suggest you do that.
jason
|
|