Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2003:
[Freeciv-Dev] Re: (PR#4725) Rename map_get_known and map_get_known_and_s
Home

[Freeciv-Dev] Re: (PR#4725) Rename map_get_known and map_get_known_and_s

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#4725) Rename map_get_known and map_get_known_and_seen to map_is_*
From: "Andy Smith" <andy@xxxxxxxxxxxxxx>
Date: Tue, 5 Aug 2003 04:09:18 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Tue, Aug 05, 2003 at 03:35:52AM -0700, Gregory Berkolaiko wrote:
> 
> On Mon, 4 Aug 2003, Jason Short wrote:
> > Good points.
> > 
> > Yet the current naming system is still broken.  We have map_is_known and
> > map_get_known2.  "known" means two different things in these function
> > names.  We need to decide on a consistent meaning and come up with a new
> > term to describe the other.  Perhaps map_is_known and map_get_known_type?
> 
> Well, map_is_known and map_get_known would be better than before.
> Is map_is_known and map_get_known_type even better?  I am not sure, but I 
> would be willing to commit any of the above naming schemes.

OK, I will provide a patch for map_get_known2() -> map_get_known_type().



[Prev in Thread] Current Thread [Next in Thread]