Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2003:
[Freeciv-Dev] Re: (PR#4725) Rename map_get_known and map_get_known_and_s
Home

[Freeciv-Dev] Re: (PR#4725) Rename map_get_known and map_get_known_and_s

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: andy@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#4725) Rename map_get_known and map_get_known_and_seen to map_is_*
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Sat, 2 Aug 2003 08:47:04 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Thu, 31 Jul 2003, Jason Short wrote:

> Andy Smith wrote:
> 
> > TODO: perhaps now rename map_get_known2() to map_get_known as the
> > name is free?  It seems silly to have a map_get_known2() where
> > there is no map_get_known().
> 
> IMO this function is a misnomer.  "known" has a well-defined meaning, 
> and this isn't it.  It should be map_get_vision_status() or something.

Err?  What's this vision status?  tile_get_known returns enum known_type 
and is very suitably named for it.  At most you can change it to 
tile_get_known_type, but I think it'd be just noise.  More so since it 
acesses tile's "known" field.

G.
k




[Prev in Thread] Current Thread [Next in Thread]