Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2003:
[Freeciv-Dev] Re: (PR#4718) topology cleanup for client autocenter code
Home

[Freeciv-Dev] Re: (PR#4718) topology cleanup for client autocenter code

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#4718) topology cleanup for client autocenter code
From: "rwetmore@xxxxxxxxxxxx" <rwetmore@xxxxxxxxxxxx>
Date: Mon, 4 Aug 2003 21:34:42 -0700
Reply-to: rt@xxxxxxxxxxxxxx

Why change the nice aesthetics of choosing a centered position which has
been the norm for some time.

There is no sense to this. Just fix iterate outwards in the trivial way and
don't throw out the baby for some unfathomably stupid reason.

Your code will almost always center on the upper left corner, or the lower
right which doesn't seem like much of a centering operation.

Cheers,
RossW
=====

Jason Short wrote:
> [jdorje - Mon Aug  4 21:03:24 2003]:
> 
> 
>>Note, "needs" is in quotations since this piece of code probably doesn't
>>have to exist at all.  It's just a 4th-level backup for finding
>>something to center on.
> 
> 
> This patch replaces the outward iteration with a standard-ordering
> iteration.  It thus is just as "efficient" but the logic is simpler and
> it may occasionally center on an inferior location (not that that matters).
> 
> jason




[Prev in Thread] Current Thread [Next in Thread]