[Freeciv-Dev] Re: (PR#4598) Cannot build Barracks III

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Jul 20, 2003 at 09:24:34PM -0700, Jason Short wrote:
> > 
> > improvement_redundant returns TRUE.  I don't know why.
> 
> Sun Tzu's is on the Barracks3 equiv_repl list - which AFAIK means
> Barracks3 _shouldn't_ be buildable when you have Sun Tzu's.  But
> apparently this isn't always correctly checked.

yes it should be buildable, since Sun Tzu's is obsoleted by Mobile Warfare
and obsolete buildings are ignored by redundancy checks. So the equiv_repl
entry is strictly not necessary (merely for symmetry with the other
barracks).

The problem was the the client wasn't getting the message that Sun Tzu's
became obsolete. Restarting the client solved the problem. Here's the fix
I'll be committing shortly.

-mike

diff -Nur -Xsnap/diff_ignore snap/client/packhand.c 
snap-barracks/client/packhand.c
--- snap/client/packhand.c      2003-07-25 23:21:07.000000000 -0500
+++ snap-barracks/client/packhand.c     2003-07-26 09:52:59.000000000 -0500
@@ -1236,9 +1236,12 @@
       need_effect_update = TRUE;
     }
   } tech_type_iterate_end;
+
   if (need_effect_update) {
-    /* nothing yet */
+    improvements_update_obsolete();
+    /* need to update effects here too eventually */
   }
+
   update_research(pplayer);
   return need_effect_update;
 }