[Freeciv-Dev] Re: (PR#4611) put the 'occupied' flag in the city_info packet

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Fri, 18 Jul 2003, Jason Short wrote:

> [jdorje - Fri Jul 18 18:37:42 2003]:
> 
> > Currently the occupied flag is only sent as part of the short_city 
> > packet.  But when the city_info packet is sent out instead the shorter 
> > packet is usually not sent.  This patch sends the 'occupied' flag along 
> > with the city_info packet as well.
> 
> Nope, this is buggy...since it sends the information without updating
> the plrtile dumb city, it can lead to inconsistent states later.  We're
> better off finding any errors and fixing them individually.

It also looks at the pcity->occupied field which is rarely updated I 
think.  So there will be many LOG_ERROR messages AFAICS.

G.