[Freeciv-Dev] Re: (PR#4596) Partisan invisible

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Jason Short wrote:
> [ChrisK@xxxxxxxx - Thu Jul 17 19:35:32 2003]:
> 
> 
>>I conquer enemy's capital and he's getting some partisans. One (or more)
>>rounds later I move an alpine troops unit and accidentally attack a
>>partisan: it is not visible even when my unit is next to it.
>>
>>Not reproducible from savegame.
> 
> 
> I can find no bug in the server; place_partisans() is very simple.  This
> could be a symptom of the ghost unit bugs we've been seeing, or an
> unrelated client bug of some sort, or an arbitrary memory overrun.

Err, that last patch was sent by mistake.  If there were to be a patch 
for this code, it would be this.

jason

? rc
Index: server/unittools.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/unittools.c,v
retrieving revision 1.233
diff -u -r1.233 unittools.c
--- server/unittools.c  2003/07/17 18:56:52     1.233
+++ server/unittools.c  2003/07/18 04:04:28
@@ -1184,6 +1184,8 @@
     punit = create_unit(city_owner(pcity), x, y, u_type, FALSE, 0, -1);
     if (can_unit_do_activity(punit, ACTIVITY_FORTIFYING)) {
       punit->activity = ACTIVITY_FORTIFIED; /* yes; directly fortified */
+      /* create_unit already calls send_unit_info; we only do it again
+       * because the activity has changed. */
       send_unit_info(NULL, punit);
     }
   }